FISH-5645 Validity Checks on Client Certificates in the Trust Store #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <[email protected]>
|
Jenkins test please |
rdebusscher
suggested changes
Sep 28, 2021
...ava/com/sun/enterprise/security/auth/realm/certificate/ClientCertificateExpiryValidator.java
Outdated
Show resolved
Hide resolved
...ava/com/sun/enterprise/security/auth/realm/certificate/ClientCertificateExpiryValidator.java
Outdated
Show resolved
Hide resolved
.../core/src/main/java/com/sun/enterprise/security/auth/realm/certificate/CertificateRealm.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JamesHillyard <[email protected]>
|
Jenkins test please |
Pandrex247
requested changes
Sep 30, 2021
Pandrex247
reviewed
Sep 30, 2021
...ava/com/sun/enterprise/security/auth/realm/certificate/ClientCertificateExpiryValidator.java
Outdated
Show resolved
Hide resolved
Pandrex247
reviewed
Sep 30, 2021
Signed-off-by: JamesHillyard <[email protected]>
|
Jenkins test please |
Pandrex247
reviewed
Oct 1, 2021
...es/client-certificate-validator/src/main/java/fish.payara.samples.security/HelloServlet.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JamesHillyard <[email protected]>
|
Jenkins test please |
Pandrex247
requested changes
Oct 1, 2021
There was a problem hiding this comment.
https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html
Package names are written in all lower case to avoid conflict with the names of classes or interfaces.
Rename to fish.payara.samples.security.client.validation or fish.payara.samples.security.client_validation (hyphens aren't allowed either).
...cate-validator/src/test/java/fish/payara/samples/security/clientValidation/MyKeyManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JamesHillyard <[email protected]>
|
Jenkins test please |
Pandrex247
approved these changes
Oct 4, 2021
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-5645 Validity Checks on Client Certificates in the Trust Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new improvement utilising the ClientCertificateValidator API with a default implementation checking for expired certificates being used in the trust store. An image of the log's warning is below.
Important Info
To prevent breaking changes this is enabled by default for community but will be disabled for Enterprise.
Testing
New tests
ClientValidationTest in the new client-certification-validation module of Payara-Samples adds an expired certificate to the trust store then attempts to make a connection to a test servlet using that expired certificate.
Testing Performed
Manually ran the test application from the JIRA and new Payara-Sample.
Testing Environment
JDK8, Maven 3.6.3, Windows 10
Documentation
Documentation PR: payara/Payara-Community-Documentation#253
Notes for Reviewers